Review of active proposal
The proposal has 16 operations, on the submitted proposal, 6 of them use parameters that differs from the tests and calldata published above. While the proposal simulation passes, if executed, it will not achieve the goal of the proposal.
Operations 2, 3, 4, 5, 6:
These operations are described in step 2 of the specification section. The differences are in some label and node arguments, which are crucial for the reverse resolution on ENSIP-19 to happen. The labelhash was probably calculated differently.
| Operation number (1 to 16) | Argument | Expected | Submitted | |
|---|---|---|---|---|
| 2 - registry.setSubnodeRecord | label | a7f8a095a00b663580c29f964c4bfc4ce8f41776d9ea5b70e2e08e69327a77bc | 7d8e29b968b7788e83efa746345c315e0cf10df6950259a7cb05ce0149b8b6e3 | |
| 3 - registry.setSubnodeRecord | label | 72c29f4186361a46935e4e9c3af71d1cf73cac00186fceb1cd1945ed9ed3dec1 | 4056cb788b3af93d9486e35f4d0aff6b21a4da32161ef55acba5a78d69dad5b6 | |
| 4 - registry.setSubnodeRecord | label | f5b2aa07eebc1b04c9923c2e20c5988f7ec95c4150e7fb00a49f74cf73ff795a | 44495acbb270e33daa2b6b957b8713b55ab4a023300855e3adeb370f8bfcd47a | |
| 5 - registry.setSubnodeRecord | label | 77f44888a7cd760c9d34db42bba63325958f70077f99de6be6b318dd388d22c2 | f66cf533d101dfb2f2352e61965e14aa7e9c4164b3bfc91cbe188645e0f16336 | |
| 6 - registry.setSubnodeRecord | label | fc94dc633606a32d73e903a0aa85e12fbe1cabc6e53ee69c1893547fda6d9691 | 2e83a9aa4cc1622acc9e36e8853598634e92fa0eb10aec9b07fc68664b2ad87e |
Operation 10
These operations are described in step 6 of the specification section. The namehash for .eth TLD is incorrect.
| Operation number (1 to 16) | Argument | Expected | Submitted | |
|---|---|---|---|---|
| 10 - ethTLDResolver.setInterface | node | 93cdeb708b7545dc668eb9280176169d1c33cfd8ed6f04690a0bcc88a93fc4ae | 58665280491fc90c59d3e71704f32f95343423627fb87cf300bb02544c671cdb |
Recommendation
Vote against the proposal that’s now live and resubmit with above parameters.