TextResolver and other resolvers

Hi,

We’re trying to use the TextResolver contract implementation for implementation of our own resolver.
To save storage costs it would be nice if we could override the getText methods.
Unfortunately the override is missing on the function call and hence we can’t use the TextResolver in its current form.

Wouldn’t it make sense to modify the contracts so at least code reuse becomes possible for third parties implementing their own resolvers?

Any thoughts?

1 Like

We’d definitely welcome a PR! It may make more sense to just write your own Text resolver replacement and include that instead of the standard one, though.

Reusing makes more sense so we can more easily follow the standard set by ensdomains.
We only need to override one text field in the TextResolver to optimize our storage.
I’ve created a pull request:

Happy merging if accepted! :slight_smile:

1 Like

Perfect! Thanks for being thorough.

1 Like